Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate logic from AppVeyor into build script #111

Conversation

pascalberger
Copy link
Member

@pascalberger pascalberger commented Nov 28, 2020

Integrate logic from AppVeyor into build script to have only a single call to build script left on CI server which allows to move more easily to other CI servers in the future (#102).

Once this is merged we can remove the additional PowerShell code from AppVeyor configuration and just call the build script.

It currently copies logic from AppVeyor into build script. Rewriting of the versioning can be done in a later PR (#109).

@pascalberger pascalberger force-pushed the feature/move-appveyor-logic-to-build-script branch from ee33c00 to 4be3814 Compare November 28, 2020 12:38
@pascalberger pascalberger marked this pull request as ready for review November 28, 2020 12:38
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit b0a0df9 into magic-chunks:master Nov 28, 2020
@gep13
Copy link
Member

gep13 commented Nov 28, 2020

@pascalberger your changes have been merged, thanks for your contribution 👍

@pascalberger pascalberger deleted the feature/move-appveyor-logic-to-build-script branch November 28, 2020 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants