Fix getAddressData in MailchimpTags build #1228
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
\Ebizmarts_MailChimp_Model_Api_Subscribers_MailchimpTags::getAddressData
method appears to be wrong and this PR aims to fix it.Prior to this PR:
getAddressData
method returns an instance ofMage_Sales_Model_Address
instead of an array. This cause an empty JSON object passed to Mailchimp API which leads to the "Data did not match any of the schemas described in anyOf" error.After this PR, if the customer has a default billing/shipping address it will be always exported as the BILLING/SHIPPING tags regardless the presence of any order.