Optimise boot speed + remove the need for traverse #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks amazing. Thank you for the contribution. Changing the API boot time from 45 seconds to a few milliseconds is really awesome. It would be great if you can add your company to the following issue: #59 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've got a fairly sizable set of protos and we were noticing some really bad startup performance on our APIs. I did some profiling and found that Mali was hanging on
traverse()for a really long time while gathering service definitions.This PR switches traverse for a lighter implementation that still scans the full object passed to
getServiceDefinitionsand avoids circular object refs / checking nodes twice all while being a whole lot faster than the current method.These changes brought our API startup time down from 45 seconds to a few milliseconds.