fix: evade parsing of pmtiles with NSURL #625
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@conbrad could you please also have a look at this? |
tyrauber
reviewed
Jan 20, 2025
Looks reasonable, however is it possible to simplify, remove the conditional block and just always use Regarding @tyrauber 's comment , I believe PMTiles relies solely on HTTP headers, so URL params shouldn't be a factor, unless of course you're using params through a proxy or something... |
|
@conbrad see my comment here maplibre/maplibre-native#3151 (comment) regarding only using |
|
I've posted a workaround to the issue. Therefore lets wait for the release of the fix maplibre/maplibre-native#3163 upstream, then I will adopt this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #618
To test, use this Bug Report example #618 (comment)
Now it also works on iOS 17.