Remove hardcode references to MacOSX10.12.sdk #198
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Asbjørn Sloth Tønnesen <[email protected]>
Now that printing isn't loaded automatically it must be loaded explicitly. Fixes: 4f7f090 An attempt to solve printing import error Signed-off-by: Asbjørn Sloth Tønnesen <[email protected]>
- The 3.0.13-1 package builds mapnik without a soname - This takes advantage of that by expecting a non-versioned, non-symlink library name on linux - This is important when packaging portable binaries to avoid copying only a symlink and leaving a broken install
Pin 3.0.x branch against Mapnik 3.0.x mason package
Fix python3 compatible in printing.
Avoid redefining Pycairo_CAPI
|
Thank you for the information. However, I don't see how merging v3.0.x branch into master can help with the issue. Also it is not needed or desirable to use mason-packages for running python-mapnik. The only reason for mason-packages is to provide versions of dependencies under which visual tests are passing. This is not needed unless you want to participate in development of Mapnik. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With reference to issue #167
In the mason-packages, there are hardcoded references to MacOSX10.12.sdk for the xcode sdks required to build mapnik._mapnik extension. If you install xcode on a mac today, the included SDK is MacOSX 10.14, which won't work for building python-mapnik because mason is looking for version 10.12. The new SDK isn't named MacOSX.sdk anymore, it is now called simply MacOSX.sdk thus versioned names aren't necessary.