PHP support via. Phpactor #129
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it's better to implement this in a different repo. Here are the examples of implementing completers in its own repo: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for PHP via phpactor.
Phpactor currently provides real completion for member access (methods, properties and constants), and can provide more options in the future (e.g. new classes, local variables, etc).
Unlike most "completion backends" it does not use a database index, and relies on the PHP package manager (composer) to locate classes - which means it will not work on the very rare projects which do not use composer.
It is also still under development so is potentially unstable. For this reason I don't recommend merging it yet - but just wanted to register the idea and see if it would be eligible for merging in the future.