Merge pull request #800 from markfairbanks/group_by-no-rename

Don't allow renaming in `group_by()`

NEWS.md

@@ -1,5 +1,8 @@
 # tidytable 0.11.1 (in development)
 
+#### Bug fixes
+* Attempting to rename columns using `group_by()` now leads to an error (#799)
+
 # tidytable 0.11.0
 
 #### Functionality improvements

R/group_by.R

@@ -36,7 +36,7 @@ group_by <- function(.df, ..., .add = FALSE) {
 group_by.tidytable <- function(.df, ..., .add = FALSE) {
   dots <- enquos(...)
   check_no_across(dots)
-  .groups <- tidyselect_names(.df, !!!dots)
+  .groups <- tidyselect_names(.df, !!!dots, .allow_rename = FALSE)
   if (length(.groups) == 0) {
     out <- .df
   } else {

R/utils-tidyselect.R

@@ -2,14 +2,14 @@
 # _names: Get column names (as a character vector)
 # _syms: Get column names (as a list of symbols)
 
-tidyselect_locs <- function(.df, ...) {
-  eval_select(expr(c(...)), .df)
+tidyselect_locs <- function(.df, ..., .allow_rename = TRUE) {
+  eval_select(expr(c(...)), .df, allow_rename = .allow_rename)
 }
 
-tidyselect_names <- function(.df, ...) {
-  names(tidyselect_locs(.df, ...))
+tidyselect_names <- function(.df, ..., .allow_rename = TRUE) {
+  names(tidyselect_locs(.df, ..., .allow_rename = .allow_rename))
 }
 
-tidyselect_syms <- function(.df, ...) {
-  syms(tidyselect_names(.df, ...))
+tidyselect_syms <- function(.df, ..., .allow_rename = TRUE) {
+  syms(tidyselect_names(.df, ..., .allow_rename = .allow_rename))
 }

tests/testthat/test-group_by.R

@@ -18,6 +18,16 @@ test_that("group_by works with .add", {
   expect_true(is_grouped_df(res))
 })
 
+test_that("group_by errors on rename, #799", {
+  df <- tidytable(x = c("a", "a", "b"),
+                  y = 1:3)
+  expect_error(
+    group_by(df, new_x = x)
+  )
+})
+
+##### ungroup() -------------------------------------------
+
 test_that("works on rowwise_tt", {
   df <- rowwise(tidytable(x = 1:3, y = 1:3))
   res <- ungroup(df)