Better handling of i and j in dt()

DESCRIPTION

@@ -24,7 +24,7 @@ Imports:
     rlang (>= 1.1.0),
     tidyselect (>= 1.2.0),
     vctrs (>= 0.6.0)
-RoxygenNote: 7.2.3
+RoxygenNote: 7.3.1
 Roxygen: list(markdown = TRUE)
 Config/testthat/edition: 3
 URL: https://markfairbanks.github.io/tidytable/, https://github.com/markfairbanks/tidytable

NAMESPACE

@@ -306,6 +306,13 @@ import(data.table, except = c(between, fread))
 import(rlang, except = `:=`)
 import(tidyselect)
 import(vctrs)
+importFrom(data.table,"%between%")
+importFrom(data.table,"%chin%")
+importFrom(data.table,"%like%")
+importFrom(data.table,data.table)
+importFrom(data.table,fwrite)
+importFrom(data.table,getDTthreads)
+importFrom(data.table,setDTthreads)
 importFrom(glue,glue)
 importFrom(glue,glue_collapse)
 importFrom(glue,glue_data)
@@ -316,7 +323,27 @@ importFrom(magrittr,set_class)
 importFrom(pillar,dim_desc)
 importFrom(pillar,glimpse)
 importFrom(pillar,tbl_sum)
+importFrom(rlang,enexpr)
+importFrom(rlang,enexprs)
+importFrom(rlang,enquo)
+importFrom(rlang,enquos)
+importFrom(rlang,expr)
+importFrom(rlang,exprs)
+importFrom(rlang,quo)
+importFrom(rlang,quos)
+importFrom(rlang,sym)
+importFrom(rlang,syms)
 importFrom(stats,na.omit)
+importFrom(tidyselect,all_of)
+importFrom(tidyselect,any_of)
+importFrom(tidyselect,contains)
+importFrom(tidyselect,ends_with)
+importFrom(tidyselect,everything)
+importFrom(tidyselect,last_col)
+importFrom(tidyselect,matches)
+importFrom(tidyselect,num_range)
+importFrom(tidyselect,starts_with)
+importFrom(tidyselect,where)
 importFrom(utils,head)
 importFrom(utils,tail)
 importFrom(utils,type.convert)

R/dt.R

@@ -8,7 +8,9 @@
 #' Has experimental support for tidy evaluation for custom functions.
 #'
 #' @param .df A data.frame or data.table
-#' @param ... Arguments passed to data.table call. See ``?data.table::`[.data.table` ``
+#' @param i i position of a data.table call. See `?data.table::data.table`
+#' @param j j position of a data.table call. See `?data.table::data.table`
+#' @param ... Other arguments passed to data.table call. See `?data.table::data.table`
 #'
 #' @examples
 #' df <- tidytable(
@@ -30,13 +32,13 @@
 #' df %>%
 #'   add_one(x)
 #' @export
-dt <- function(.df, ...) {
+dt <- function(.df, i, j, ...) {
   UseMethod("dt")
 }
 
 #' @export
-dt.tidytable <- function(.df, ...) {
-  dots <- enquos(..., .unquote_names = FALSE, .ignore_empty = "none")
+dt.tidytable <- function(.df, i, j, ...) {
+  dots <- enquos(i, j, ..., .unquote_names = FALSE, .ignore_empty = "none")
 
   if (has_length(dots, 0)) return(.df)
 
@@ -94,9 +96,9 @@ dt.tidytable <- function(.df, ...) {
 }
 
 #' @export
-dt.data.frame <- function(.df, ...) {
+dt.data.frame <- function(.df, i, j, ...) {
   .df <- as_tidytable(.df)
-  dt(.df, ...)
+  dt(.df, {{ i }}, {{ j }}, ...)
 }
 
 # Checks if j is a single call to `:=` or let

R/utils-general.R

@@ -1,8 +1,6 @@
 # dt starting with the j position
 dt_j <- function(.df, j, ...) {
-  j <- enquo(j)
-  i <- new_quosure(expr(), get_env(j))
-  dt(.df, !!i, !!j, ...)
+  dt(.df, , {{ j }}, ...)
 }
 
 # Create a call to `[.data.table` (j position)