Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add controls on config file #59

Merged
merged 5 commits into from
Sep 4, 2023
Merged

Add controls on config file #59

merged 5 commits into from
Sep 4, 2023

Conversation

JulienMattiussi
Copy link
Contributor

@JulienMattiussi JulienMattiussi commented Aug 9, 2023 •
edited
Loading

Trello card #678

  • Specific error when config file is not found (excepted for default config file wich can be ignored)
  • Specific error when config file is not a yaml

Nitix
Nitix reviewed Aug 9, 2023
View reviewed changes
src/services/parseConfigFile.js Outdated
} catch {
// Do Nothing
} catch (error) {
if (path !== analyze.DEFAULT_CONFIG_FILE || error.code !== FILE_NOT_FOUND) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it work with optional default config file?

@erwanMarmelab erwanMarmelab merged commit 66a3f3a into main Sep 4, 2023
7 checks passed
@erwanMarmelab erwanMarmelab deleted the test-config-file branch September 4, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nitix Nitix Nitix left review comments

@benoitchazoule benoitchazoule benoitchazoule approved these changes

@erwanMarmelab erwanMarmelab erwanMarmelab approved these changes

Assignees
No one assigned
Labels
RFR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JulienMattiussi @Nitix @benoitchazoule @erwanMarmelab