fix potential data race

marwan-at-work · Nov 16, 2023 · ff7604c · ff7604c
1 parent 3aa359b
commit ff7604c
Showing 1 changed file with 1 addition and 11 deletions.
diff --git a/client/client.go b/client/client.go
@@ -114,12 +114,12 @@ func (c *Client) readWorker(ctx context.Context) {
 		}
 		c.mu.Lock()
 		ch, ok := c.rpcs[resp.GetId()]
+		delete(c.rpcs, resp.GetId())
 		c.mu.Unlock()
 		if !ok {
 			fmt.Fprintf(os.Stderr, "could not find call for %d: %v\n", resp.GetId(), &resp)
 			continue
 		}
-		delete(c.rpcs, resp.GetId())
 		ch <- &resp
 	}
 }
@@ -160,13 +160,3 @@ func (c *Client) Close() error {
 func id(i int64) *int64 {
 	return &i
 }
-
-func str(s string) *string {
-	return &s
-}
-
-func must(err error) {
-	if err != nil {
-		panic(err)
-	}
-}