-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sfu-to-sfu talk MSC3401 and add new features #11
Conversation
type LocalTrackWithInfo struct { | ||
Track *webrtc.TrackLocalStaticRTP | ||
Info LocalTrackInfo | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This now looks like an idea much worse than when I first thought of it... This could definitely be done differently now though I think it makes sense to just try to redo this during switching to using a pool of streams since that might change the design again...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looking good. Main things are proper (or at least some) error handling rather than panicking and making sure member functions aren't public unnecessarily. We'll also want to hook up logrus or whatever people use now at some point soon, but probably not in this PR.
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Yep, that has been my thoughts since the fist time I actually need to debug it based on logs :P Sorry, for the Go newbie mistakes, hopefully, it looks better now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good other than the ice password. Presumably we're blocked on the mautrix-go PR now?
Thank you!
Since I expect some of the events to change shape with further development, I'd hold off and wait and get that merged when we're more sure things are not going to change radically |
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Fixes #13
Implements MSC3401 SFU bits
Requires matrix-org/matrix-js-sdk#2423
Requires mautrix/go#77