Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update integrations.rst #193

Open
wants to merge 2 commits into
base: 5.x
Choose a base branch
from
Open

Update integrations.rst #193

wants to merge 2 commits into from

Conversation

putzwasser
Copy link

Adds a note on the correct naming of HelloWorldIntegration::NAME

RCheesley
RCheesley requested changes Jun 17, 2024
View reviewed changes
Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @putzwasser just a couple of things to tweak.

docs/components/integrations.rst Outdated Show resolved Hide resolved
@putzwasser @RCheesley
FIX: Backticks
3547974 
Co-authored-by: Ruth Cheesley <[email protected]>
@putzwasser
Copy link
Author

Fixed.

RCheesley
RCheesley approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the tweaks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RCheesley RCheesley RCheesley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@putzwasser @RCheesley