Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dependencies #157

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove unused dependencies #157

wants to merge 1 commit into from

Conversation

J0WI
Copy link

@J0WI J0WI commented Mar 28, 2020

This PR remove unused dependencies, namely:

  • git, sudo and zip
  • wget (replaced with curl)
  • cron and unzip (replaced with BusyBox)
  • build dependencies (*-dev)

The chmod +x statement is not needed if the executable bit is tracked with Git.
I also merged parts of #146, so the GD extension is already included here.

@luizeof
Copy link
Member

luizeof commented Mar 28, 2020

Thanks for your Pull ..

I recommend sending a few changes by yourself, as this greatly changes the way thousands of mautic users deal with crons, etc.

git is used to make it possible to install github dependencies and plugins.

sudo is necessary to execute commands on the command line without hurting the log permissions.

@J0WI
Copy link
Author

J0WI commented Mar 28, 2020

sudo is necessary to execute commands on the command line without hurting the log permissions.

sudo should be avoided in docker. You can use docker exec -u.

git is used to make it possible to install github dependencies and plugins.

The documentation doesn't motion this procedure: https://docs.mautic.org/en/plugins#install-plugins

The cron replacement may need some further testing, but I'm pretty sure that BusyBox can be used as a drop-in replacement. In general it's not recommend to run a cron daemon in a container anyway. A sidecar container or docker exec on the host are the preferred solutions.

@luizeof
Copy link
Member

luizeof commented Mar 28, 2020

@J0WI yes, i am happy for the contribution. I would just like to test one thing at a time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants