Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V4.4] CI: try to fix macos paths one more time #12330

Open
wants to merge 5 commits into
base: Stable_V4.4
Choose a base branch
from

Conversation

julianoes
Copy link
Contributor

No description provided.

@HTRamsey
Copy link
Collaborator

Can you explain the need for this?

@julianoes
Copy link
Contributor Author

macos-12 runners were deprecated, so I had to switch to macos-13 which broke. So, I had to figure out why it broke. Since I don't have a Mac, don't really understand the problem, I threw everything at claud.ai to fix it. I hope this time I got it.

The need for it is that I might publish V4.4.5 with a board ID backport, and potential other fixes if any come up before I hit release.

Makes sense? I'm assuming V5 is still a bit out, or is it about to be dropped?

@julianoes
Copy link
Contributor Author

Not sure why it fails at "generating the rebase commit". I assume that's a github issue? 🤷

@HTRamsey
Copy link
Collaborator

HTRamsey commented Jan 16, 2025

I was asking because I was curious if I had to do it for master too. I'm having trouble with the macos GStreamer stuff in master as well.

@HTRamsey
Copy link
Collaborator

In QGC 4.X CMake build uses prepare_gstreamer_framework.sh but qmake doesn't. Not really sure why the difference

@julianoes
Copy link
Contributor Author

Every time I re-commit this and force push it, it seems to fail again. Then I fix it and next time it fails again.

@julianoes
Copy link
Contributor Author

Well, I might actually have to think this through since throwing it at Claude.ai doesn't seem to solve it for me.

@HTRamsey
Copy link
Collaborator

@HTRamsey
Copy link
Collaborator

It's basically impossible if you don't have a mac to test on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants