-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[V4.4] CI: try to fix macos paths one more time #12330
base: Stable_V4.4
Are you sure you want to change the base?
Conversation
Can you explain the need for this? |
macos-12 runners were deprecated, so I had to switch to macos-13 which broke. So, I had to figure out why it broke. Since I don't have a Mac, don't really understand the problem, I threw everything at claud.ai to fix it. I hope this time I got it. The need for it is that I might publish V4.4.5 with a board ID backport, and potential other fixes if any come up before I hit release. Makes sense? I'm assuming V5 is still a bit out, or is it about to be dropped? |
eeb35ee
to
7f81005
Compare
Not sure why it fails at "generating the rebase commit". I assume that's a github issue? 🤷 |
I was asking because I was curious if I had to do it for master too. I'm having trouble with the macos GStreamer stuff in master as well. |
In QGC 4.X CMake build uses prepare_gstreamer_framework.sh but qmake doesn't. Not really sure why the difference |
7f81005
to
5996f0d
Compare
Every time I re-commit this and force push it, it seems to fail again. Then I fix it and next time it fails again. |
Well, I might actually have to think this through since throwing it at Claude.ai doesn't seem to solve it for me. |
It's basically impossible if you don't have a mac to test on. |
44208dd
to
2c9c2a5
Compare
No description provided.