Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update to electron 34.x.x #486

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

setchy
Copy link
Contributor

@setchy setchy commented Oct 15, 2024

Update deps using ncu, most notably [email protected]

@setchy
Copy link
Contributor Author

setchy commented Dec 1, 2024

bump to electron 33.2.1

@SeriousSem
Copy link

Any chance to merge it?

@setchy
Copy link
Contributor Author

setchy commented Feb 27, 2025

@amaury1093 👀

@setchy setchy changed the title chore(deps): update to electron 33.x.x chore(deps): update to electron 34.x.x Feb 27, 2025
@gobengo
Copy link

gobengo commented Feb 27, 2025

If I read this right, it updates to < 34, so 33?

@setchy
Copy link
Contributor Author

setchy commented Feb 27, 2025

Good catch @gobengo - i had updated #481 last night. will push updates to this branch, too

Signed-off-by: Adam Setch <[email protected]>
@setchy
Copy link
Contributor Author

setchy commented Feb 27, 2025

Updated

@gobengo
Copy link

gobengo commented Feb 27, 2025

@setchy awesome! thank you!
For now, I was just able to downgrade to electron 33 and use your branch (via git dep after adding a prepare script on my fork). yay

I made a PR to add the prepare script here so all the feature branches can easily be npm installed and still work
#489

Co-authored-by: Benjamin Goering <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants