Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exchange and currency fields to trade imports #1822

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

onyedikachi-david
Copy link

Related Issues

Fixes #1718
/claim #1718

testing.mp4

@zachgoll
Copy link
Collaborator

Hey @onyedikachi-david thanks for the submission! Just an update—we're currently working on some related data issues regarding the Security model over in #1826, so we'll need to put this one on hold for the moment as I believe the fields required for this will need to change / be updated based on where we land with that.

I'll post here when we're ready to resume work and add some comments to the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trade imports should accept a currency, exchange, and ticker field
2 participants