added support for processing schwab's tax statement #22

243826 · 2021-11-12T18:11:21Z

No description provided.

google-cla · 2021-11-12T18:11:25Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

mbrukman · 2021-11-12T19:14:20Z

Hi Chetan,

Thanks for the pull request to add support for Schwab!

The reason that you're seeing the Google CLA on this PR is that even though this is my personal project, I was employed by Google when I created it (and still work there), so the Google CLA still applies.

Please follow the instructions in the comment from the bot to address the CLA requirement, and then I'll be happy to review and merge your PR. Let me know if you have any questions or run into any issues with the CLA.

Thanks again for your contribution! Looking forward to including it in the project.

Best,
Misha

mbrukman · 2025-02-15T23:24:17Z

Hey @243826, thanks again for your contribution!

Can you please take a look at and sign the CLA? This is a required step before I can review your PR. If you have any questions or concerns, please let me know!

243826 · 2025-02-16T17:11:11Z

googlebot I signed it!

mbrukman · 2025-02-19T02:38:38Z

Thanks for signing the CLA, @243826!

Since you're adding a converter for a new broker, would you be able to add one or two unit tests, perhaps using a simplified / anonymized version of the CSV file you have from Schwab, to make sure that we don't break the behavior of the converter with future changes, updates, or refactoring?

mbrukman

Thank you very much for your contribution! Please see my comments below and let me know if you have any questions.

mbrukman · 2025-02-19T02:39:28Z

utils.py

@@ -69,7 +69,10 @@ def __str__(self):

 def txfDate(date):


Maybe it's time we add type annotations to this code, it now takes str | datetime and returns str.

mbrukman · 2025-02-19T02:40:34Z

schwab.py

+import utils
+
+
+FIRST_LINE = 'Description of property (Example 100 sh. XYZ Co.),Date acquired,Date sold or disposed,Proceeds,Cost or other basis,Accrued market discount,Wash sale loss disallowed,Short-Term gain loss Long-term gain or loss Ordinary,Form 8949 Code,Check if proceeds from collectibles QOF,Federal income tax withheld,Check if noncovered security,Reported to IRS: Gross proceeds Net proceeds,Check if loss is not allowed based on amount in 1d,Profit or (loss) realized in 2020 on closed contracts,Unrealized profit or (loss) on open contracts-12/31/2019,Unrealized profit or (loss) on open contracts-12/31/2020,Aggregate profit or (loss) on contracts,Check if basis reported to IRS,Bartering,State name,State identification no,State Tax Withheld\n'


For ease of readability, would you mind splitting these into a list of fields, and keeping them in a list, and joining them via ','.join(['Description of property ...', 'Date acquired', ... ]) + '\n'?

mbrukman · 2025-02-19T02:41:45Z

schwab.py

+        return "Charles Schwab"
+
+    @classmethod
+    def washSaleDisallowedAmount(cls, dict):


We've stopped using dict as a variable as it's also a type, please replace dict with txn and add a type annotation, it's most likely dict[str, str] here and below. See other broker files for an example.

mbrukman · 2025-02-19T02:42:09Z

schwab.py

+
+class Schwab:
+    @classmethod
+    def name(cls):


Please add a return type for this and other methods below.

mbrukman · 2025-02-19T02:43:06Z

schwab.py

+* partial lot sales
+"""
+
+import csv


Please add above:

from __future__ import annotations

This will make it easier for you to add type annotations below.

mbrukman · 2025-02-19T02:44:02Z

brokers.py



 BROKERS = {
    'amtd': TDAmeritrade,
    'ib': InteractiveBrokers,
    'tdameritrade': TDAmeritrade,
    'vanguard': Vanguard,
+    'schwab' : Schwab


Please terminate this line with a comma as above to make it easier to add / remove brokers in the future, without modifying other lines around them.

mbrukman · 2025-02-19T02:45:37Z

schwab.py

+TRANSACTION_TYPE = 'Trans type'
+
+
+class Schwab:


As mentioned in my comment on the PR, could you please add a simple unit test for this file format?

See the files in testdata directory for the format. make regen updates expected test data outputs, see update_testdata.py for what it actually does in that step.

added support for processing schwab's csv

c8abcec

google-cla bot added the cla: no PR not CLA-compliant label Nov 12, 2021

google-cla bot added cla: yes PR is CLA-compliant and removed cla: no PR not CLA-compliant labels Feb 17, 2025

mbrukman requested changes Feb 19, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added support for processing schwab's tax statement #22

added support for processing schwab's tax statement #22

243826 commented Nov 12, 2021

google-cla bot commented Nov 12, 2021

mbrukman commented Nov 12, 2021

mbrukman commented Feb 15, 2025

243826 commented Feb 16, 2025

mbrukman commented Feb 19, 2025

mbrukman left a comment

mbrukman Feb 19, 2025

mbrukman Feb 19, 2025

mbrukman Feb 19, 2025

mbrukman Feb 19, 2025

mbrukman Feb 19, 2025

mbrukman Feb 19, 2025

mbrukman Feb 19, 2025

		import utils


		FIRST_LINE = 'Description of property (Example 100 sh. XYZ Co.),Date acquired,Date sold or disposed,Proceeds,Cost or other basis,Accrued market discount,Wash sale loss disallowed,Short-Term gain loss Long-term gain or loss Ordinary,Form 8949 Code,Check if proceeds from collectibles QOF,Federal income tax withheld,Check if noncovered security,Reported to IRS: Gross proceeds Net proceeds,Check if loss is not allowed based on amount in 1d,Profit or (loss) realized in 2020 on closed contracts,Unrealized profit or (loss) on open contracts-12/31/2019,Unrealized profit or (loss) on open contracts-12/31/2020,Aggregate profit or (loss) on contracts,Check if basis reported to IRS,Bartering,State name,State identification no,State Tax Withheld\n'

added support for processing schwab's tax statement #22

Are you sure you want to change the base?

added support for processing schwab's tax statement #22

Conversation

243826 commented Nov 12, 2021

google-cla bot commented Nov 12, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

mbrukman commented Nov 12, 2021

mbrukman commented Feb 15, 2025

243826 commented Feb 16, 2025

mbrukman commented Feb 19, 2025

mbrukman left a comment

Choose a reason for hiding this comment

mbrukman Feb 19, 2025

Choose a reason for hiding this comment

mbrukman Feb 19, 2025

Choose a reason for hiding this comment

mbrukman Feb 19, 2025

Choose a reason for hiding this comment

mbrukman Feb 19, 2025

Choose a reason for hiding this comment

mbrukman Feb 19, 2025

Choose a reason for hiding this comment

mbrukman Feb 19, 2025

Choose a reason for hiding this comment

mbrukman Feb 19, 2025

Choose a reason for hiding this comment