Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New pages: SVGSVGElement API properties #37281

Merged
merged 10 commits into from
Feb 14, 2025
Merged

New pages: SVGSVGElement API properties #37281

merged 10 commits into from
Feb 14, 2025

Conversation

estelle
Copy link
Member

@estelle estelle commented Dec 19, 2024

@estelle estelle requested a review from a team as a code owner December 19, 2024 22:40
@estelle estelle requested review from sideshowbarker and removed request for a team December 19, 2024 22:40
@github-actions github-actions bot added Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed labels Dec 19, 2024
Copy link
Contributor

github-actions bot commented Dec 19, 2024

@estelle estelle requested a review from wbamberg January 29, 2025 22:05
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have issues with this but I am not sure how far we want to go to address them. I find the descriptions in width and height very repetitive and quite confusing.

It's confusing that they are repetitive but organized differently, with essentially the same sentences placed in a different order, and I don't understand the rationale for this.

It seems like the general considerations are the same for width and height, so ideally we would have some guide page about this that covers the concept (including examples to show what's happening), that both these reference pages can refer to.

But even if we didn't want to factor this into a separate guide, I think these explanations are really hard to understand.

@sideshowbarker sideshowbarker removed their request for review January 31, 2025 13:28
@estelle estelle requested a review from wbamberg February 6, 2025 00:16
@estelle
Copy link
Member Author

estelle commented Feb 6, 2025

But even if we didn't want to factor this into a separate guide, I think these explanations are really hard to understand.

I shrank width and height down to just the relevant parts, and removed the guidish content. We likely should add it, but not here, and not today

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you Estelle!

@wbamberg wbamberg merged commit be7ff0e into main Feb 14, 2025
12 checks passed
@wbamberg wbamberg deleted the viewbox branch February 14, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants