DRAFT: Differentiate between two guides #37663
Conversation
github-actions
bot
added
Content:CSS
There was a problem hiding this comment.
@estelle these changes make sense, although I did have some comments about consistently using the article title as the link text. Some of the choices of link text here seem a bit weird to me.
| @@ -248,7 +248,7 @@ In [block layout](/en-US/docs/Web/CSS/CSS_box_alignment/Box_alignment_in_block_a | |||
|
|
|||
| - [Basic concepts of flexbox](/en-US/docs/Web/CSS/CSS_flexible_box_layout/Basic_concepts_of_flexbox) | |||
| - [Aligning items in a flex container](/en-US/docs/Web/CSS/CSS_flexible_box_layout/Aligning_items_in_a_flex_container) | |||
| - [Box alignment in CSS grid layouts](/en-US/docs/Web/CSS/CSS_grid_layout/Box_alignment_in_grid_layout) | |||
| - [Box alignment in CSS grid layouts](/en-US/docs/Web/CSS/CSS_box_alignment/Box_alignment_in_grid_layout) | |||
There was a problem hiding this comment.
It feels like a bit of a nitpick, but should you use the actual name of the article on links like this, where you are providing the name of the article as the link text?
The actual name is "Box alignment in grid layout".
| @@ -74,4 +74,4 @@ The grid specification originally contained the definition for the properties {{ | |||
| - [Box alignment in multiple-column layout](/en-US/docs/Web/CSS/CSS_box_alignment/Box_alignment_in_multi-column_layout) | |||
| - [Box alignment for block, absolutely positioned and table layout](/en-US/docs/Web/CSS/CSS_box_alignment/Box_alignment_in_block_abspos_tables) | |||
|
|
|||
| - [Alignment in grid layout](/en-US/docs/Web/CSS/CSS_grid_layout/Box_alignment_in_grid_layout) | |||
| - [Aligning items in CSS grid layout](/en-US/docs/Web/CSS/CSS_grid_layout/Box_alignment_in_grid_layout) | |||
There was a problem hiding this comment.
This link text is totally different to the article title, for seemingly no reason. "Box alignment in grid layout"?
They should all be consistent with each other, in cases where it makes sense to use the article title as the link text.
There was a problem hiding this comment.
That article had its name changed but is still in draft. I can draft this PR until they're both ready to go.
There was a problem hiding this comment.
Ah, OK. Yup, sounds like a good idea
estelle
changed the title
|
This pull request has merge conflicts that must be resolved before it can be merged. |
|
For the conflict, |
|
moved to #38009 |
Two guides had the exact same name.
This changes some of the links to the guide more appropriate for the content and changes the name of the guide for the links pointing to the grid item alignment guide.
The guide itself has been updated in a separate PR.
I am separating this out because that PR is getting huge.
part of openwebdocs/project#216
the guide is in draft, but not linking to the particular PR as the draft PR keeps getting borked so the # may change.