Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Temporal] Clarify assumed defaults in language by making them explicit #38006

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

0xdevalias
Copy link
Contributor

@0xdevalias 0xdevalias commented Feb 6, 2025

Description

  • Tweaks the wording to explicitly clarify the assumed default of a positive integer when referring to year / month / etc.
  • Replaces "monotonously" with "monotonically"
    • monotonous | məˈnɒtənəs |
      adjective
      dull, tedious, and repetitious; lacking in variety and interest: the statistics that he quotes with monotonous regularity.

    • monotonic | ˌmɒnəˈtɒnɪk |
      adjective
      1 Mathematics (of a function or quantity) varying in such a way that it either never decreases or never increases.

  • Tweaks to the wording to explicitly clarify the assumed default of 7 days in a week

Motivation

When I was first reading this section, I was confused as to why 'zero' and 'negative' were explicitly called out, but 'positive' wasn't; which made me wonder if 'negative' as actually intended, or a typo/etc.

Additional details

Based on request for review in:

Related issues and pull requests

@0xdevalias 0xdevalias requested a review from a team as a code owner February 6, 2025 22:56
@0xdevalias 0xdevalias requested review from Josh-Cena and removed request for a team February 6, 2025 22:56
@github-actions github-actions bot added Content:JS JavaScript docs size/xs [PR only] 0-5 LoC changed labels Feb 6, 2025
@Josh-Cena
Copy link
Member

Do you want to add your fix for the other issue to this PR too? And potentially anything else you want to add before we merge.

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Preview URLs

(comment last updated: 2025-02-06 23:20:44)

@0xdevalias
Copy link
Contributor Author

Do you want to add your fix for the other issue to this PR too? And potentially anything else you want to add before we merge.

@Josh-Cena Yeah sure, happy to do that. Wasn't sure if you'd prefer them separate or not.

Also just noticed one other tweak ("monotonously" vs "monotonically": 181cfdc) that I just fixed up here.

Give me a minute and I will add a fix for this too, then I'll be done:

@0xdevalias 0xdevalias changed the title [Temportal] Clarify assumed default of positive when referring to year [Temportal] Clarify assumed defaults in language by making them explicit Feb 6, 2025
@0xdevalias 0xdevalias changed the title [Temportal] Clarify assumed defaults in language by making them explicit [Temporal] Clarify assumed defaults in language by making them explicit Feb 6, 2025
@0xdevalias
Copy link
Contributor Author

@Josh-Cena I have made all my changes for both issues now; nothing more I want to add before merge 🖤

Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! TIL that "monotonically" and "monotonously" are not synonyms.

@Josh-Cena Josh-Cena merged commit 04a4f09 into mdn:main Feb 7, 2025
8 checks passed
@0xdevalias 0xdevalias deleted the patch-1 branch February 7, 2025 01:48
@0xdevalias
Copy link
Contributor Author

TIL that "monotonically" and "monotonously" are not synonyms.

Haha yeah. I didn't even notice that it was changed in the ChatGPT version at first; until I was making the localised changes in this PR and got confused why it said 'monotonously' (and went searching the git blame for when that change happened; till I realised it never existed and ChatGPT just made an additional fix to my sentence than I was expecting 😅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:JS JavaScript docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
2 participants