-
Notifications
You must be signed in to change notification settings - Fork 22.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Temporal] Clarify assumed defaults in language by making them explicit #38006
Conversation
Do you want to add your fix for the other issue to this PR too? And potentially anything else you want to add before we merge. |
Preview URLs (comment last updated: 2025-02-06 23:20:44) |
@Josh-Cena Yeah sure, happy to do that. Wasn't sure if you'd prefer them separate or not. Also just noticed one other tweak ("monotonously" vs "monotonically": 181cfdc) that I just fixed up here. Give me a minute and I will add a fix for this too, then I'll be done: |
year
@Josh-Cena I have made all my changes for both issues now; nothing more I want to add before merge 🖤 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! TIL that "monotonically" and "monotonously" are not synonyms.
Haha yeah. I didn't even notice that it was changed in the ChatGPT version at first; until I was making the localised changes in this PR and got confused why it said 'monotonously' (and went searching the git blame for when that change happened; till I realised it never existed and ChatGPT just made an additional fix to my sentence than I was expecting 😅) |
Description
year
/month
/ etc.7
days in a weekMotivation
When I was first reading this section, I was confused as to why 'zero' and 'negative' were explicitly called out, but 'positive' wasn't; which made me wonder if 'negative' as actually intended, or a typo/etc.
Additional details
Based on request for review in:
Related issues and pull requests