Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update zh-cn translation of cssref sidebar #38102

Merged
merged 4 commits into from
Feb 13, 2025
Merged

Conversation

jasonren0403
Copy link
Contributor

Description

Motivation

Additional details

Related issues and pull requests

part of mdn/translated-content#13881

@jasonren0403 jasonren0403 requested a review from a team as a code owner February 11, 2025 09:36
@github-actions github-actions bot added the size/s [PR only] 6-50 LoC changed label Feb 11, 2025
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one nit. Otherwise the change looks good to me!

files/sidebars/cssref.yaml Outdated Show resolved Hide resolved
Comment on lines +485 to 492
Beginners: 初学者教程
Styling_the_content: 你的第一个网站:样式化内容
CSS_styling_basics: CSS 样式基础
CSS_text_styling: CSS 文本样式
Containment: CSS 局限
CSS_layout: CSS 布局概述
Combinators: 关系选择器
Guides: 指南
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @bsmth. BTW, I want to know in what order we should sort these keys. Should we order them in the order they appear in the sidebar key above?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you have to worry about that -> they should be sorted via yarn content fmt-sidebars, if you'd like to try, it probably alpha sorts them.

Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot added merge conflicts 🚧 [PR only] size/m [PR only] 51-500 LoC changed and removed size/s [PR only] 6-50 LoC changed labels Feb 13, 2025
@github-actions github-actions bot added size/s [PR only] 6-50 LoC changed and removed merge conflicts 🚧 [PR only] size/m [PR only] 51-500 LoC changed labels Feb 13, 2025
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also +1 from me, thank you, both!

@bsmth bsmth merged commit db28b9f into mdn:main Feb 13, 2025
6 checks passed
@jasonren0403 jasonren0403 deleted the patch-5 branch February 13, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants