Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

page type: custom props are properties #38123

Merged
merged 1 commit into from
Feb 12, 2025
Merged

page type: custom props are properties #38123

merged 1 commit into from
Feb 12, 2025

Conversation

estelle
Copy link
Member

@estelle estelle commented Feb 12, 2025

this is a feature page, not a guide.

@estelle estelle requested a review from a team as a code owner February 12, 2025 06:47
@estelle estelle requested review from chrisdavidmills and removed request for a team February 12, 2025 06:47
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/xs [PR only] 0-5 LoC changed labels Feb 12, 2025
@github-actions GitHub Actions
Copy link
Contributor

Preview URLs

Flaws (2)

URL: /en-US/docs/Web/CSS/--*
Title: Custom properties (--*): CSS variables
Flaw count: 2

  • broken_links:
    • /en-US/docs/Web/CSS/inheritance is ill cased
  • macros:
    • Macro produces link /en-US/docs/Web/CSS/inheritance which is a redirect

chrisdavidmills
chrisdavidmills approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chrisdavidmills chrisdavidmills merged commit 87066b2 into main Feb 12, 2025
11 checks passed
@chrisdavidmills chrisdavidmills deleted the estelle-patch-2 branch February 12, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdavidmills chrisdavidmills chrisdavidmills approved these changes

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@estelle @chrisdavidmills