Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing return statement #38128

Merged
merged 2 commits into from
Feb 12, 2025
Merged

add missing return statement #38128

merged 2 commits into from
Feb 12, 2025

Conversation

mindplay-dk
Copy link
Contributor

Description

if the abort signal has already been fired, this function should not continue making a request (or whatever the "main purpose of the API" might be) or setting up an event listener that will never be called.

if abort has already been signaled, this function should not continue making a request or setting up an event listener
@mindplay-dk mindplay-dk requested a review from a team as a code owner February 12, 2025 14:32
@mindplay-dk mindplay-dk requested review from sideshowbarker and removed request for a team February 12, 2025 14:32
@github-actions github-actions bot added Content:WebAPI Web API docs size/xs [PR only] 0-5 LoC changed labels Feb 12, 2025
Copy link
Contributor

github-actions bot commented Feb 12, 2025

@Josh-Cena Josh-Cena requested a review from a team as a code owner February 12, 2025 21:29
@github-actions github-actions bot added the Content:Learn Learning area docs label Feb 12, 2025
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Thanks

@Josh-Cena Josh-Cena merged commit 594eb75 into mdn:main Feb 12, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Learn Learning area docs Content:WebAPI Web API docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants