Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link #2508

Merged
merged 3 commits into from
Jul 7, 2024
Merged

Fix link #2508

merged 3 commits into from
Jul 7, 2024

Conversation

artola
Copy link
Contributor

@artola artola commented Jul 7, 2024

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

The documentation says:

@mdx-js/mdx is a unified pipeline — wrapped so that most folks don’t need to know about unified: core.js#L65.

and such line states:

@Property {string | null | undefined} [pragma='React.createElement']

I would suggest to avoid linking to the source code, as it is likely to be broken again. Even a permalink will become obsolete overtime.

Copy link

vercel bot commented Jul 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mdx ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2024 6:11pm

@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (908ff45) to head (4e9c965).
Report is 34 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #2508   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines         2693      2712   +19     
  Branches         2         2           
=========================================
+ Hits          2693      2712   +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

packages/mdx/readme.md Outdated Show resolved Hide resolved
@wooorm wooorm changed the title fix broken link Fix link Jul 7, 2024
@wooorm wooorm merged commit f1ca4b2 into mdx-js:main Jul 7, 2024
5 checks passed
@wooorm wooorm added the 💪 phase/solved Post is done label Jul 7, 2024
@wooorm
Copy link
Member

wooorm commented Jul 7, 2024

Thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 phase/solved Post is done
Development

Successfully merging this pull request may close these issues.

3 participants