Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: address React 19 peer dependency issues #829

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Conversation

chrisvxd
Copy link
Member

@chrisvxd chrisvxd commented Jan 23, 2025

  1. Include dnd-kit as part of bundle, as I believe this was originally excluded due to a lack of source maps, which were added in build: generate source maps during build clauderic/dnd-kit#1567. Results in "AutoScroller plugin depends on Scroller plugin"
  2. Upgrade to latest dnd-kit, once the necessary peer-dependencies are added (React 19 (experimental) clauderic/dnd-kit#1590) (update: merged, waiting on nightly release)

Closes #826

Copy link

vercel bot commented Jan 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
puck-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 6:48pm
puck-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 6:48pm

@chrisvxd chrisvxd force-pushed the 826-peer-dep-issues branch from e2a6f8b to a70dfa2 Compare January 24, 2025 18:39
@vercel vercel bot temporarily deployed to Preview – puck-demo January 24, 2025 18:44 Inactive
@chrisvxd chrisvxd force-pushed the 826-peer-dep-issues branch from a70dfa2 to 486a863 Compare January 24, 2025 18:44
@chrisvxd chrisvxd marked this pull request as ready for review January 24, 2025 18:49
@chrisvxd chrisvxd merged commit 7649086 into main Jan 24, 2025
6 checks passed
@chrisvxd chrisvxd deleted the 826-peer-dep-issues branch January 24, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency issues with React 19
1 participant