Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add new i18n validation workflows for the admin #9948

Merged
merged 26 commits into from
Nov 10, 2024

Conversation

adrien2p
Copy link
Member

@adrien2p adrien2p commented Nov 6, 2024

RESOLVES FRMW-2767

What
Currently, for every translation PR Kap run the validation manually which is not optimal. This PR aims to improve the process by adding a new workflow that runs the validation automatically on all newly created translation file (not the update ones) in order to catch the potential issues directly from the PR without running anything manually and therefor lighten the overall process for translation PR's

cc @kasperkristensen

Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 9, 2024 7:38pm
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2024 7:38pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Nov 9, 2024 7:38pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Nov 9, 2024 7:38pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Nov 9, 2024 7:38pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Nov 9, 2024 7:38pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Nov 9, 2024 7:38pm

Copy link

changeset-bot bot commented Nov 6, 2024

⚠️ No Changeset found

Latest commit: a65ce15

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@adrien2p adrien2p merged commit 2512eef into develop Nov 10, 2024
23 checks passed
@kodiakhq kodiakhq bot deleted the chore/i18n-admin-validation branch November 10, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants