Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle non-FHS systems #12

Merged
merged 6 commits into from
Jan 12, 2020
Merged

handle non-FHS systems #12

merged 6 commits into from
Jan 12, 2020

Conversation

mitnk
Copy link
Contributor

@mitnk mitnk commented Apr 27, 2019

Fixes #11

@mitnk
Copy link
Contributor Author

mitnk commented Apr 27, 2019

Replaced env::home_dir() with dirs::home_dir() as rustc suggests:

warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
   --> src/database.rs:170:28
    |
170 |             if let Some(mut home) = env::home_dir() {
    |                                     ^^^^^^^^^^^^^
    |
    = note: #[warn(deprecated)] on by default

For the CI fails, I don't know the reason. Master fails too #10. Could you help to have a check?

@mitnk mitnk mentioned this pull request Aug 25, 2019
@mitnk
Copy link
Contributor Author

mitnk commented Jan 12, 2020

This PR is ready for another review. Thanks!

@meh
Copy link
Owner

meh commented Jan 12, 2020

Can you remove the version bump? I usually do that in another commit.

Looks good otherwise, I'll merge as soon as that's removed 🐼

@meh meh merged commit 5a84109 into meh:master Jan 12, 2020
@meh
Copy link
Owner

meh commented Jan 12, 2020

Thanks a bunch!

@mitnk mitnk deleted the handle-non-fhs branch January 12, 2020 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not Work in Termux
2 participants