gdb multi-arch v14.1 #68
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Note: this replaces #39 , since 14.1 is now available. |
nihalgonsalves
approved these changes
Dec 4, 2023
| @@ -10,7 +10,9 @@ jobs: | |||
| name: 🛠️ build on ${{ matrix.platform }} | |||
|
|
|||
| strategy: | |||
| fail-fast: true | |||
| # let all jobs run to completion. the linux one may succeed when the mac | |||
| # fails (taking a completely random example scenario 😑) | |||
README.md
Outdated
| @@ -116,7 +116,7 @@ and download the "packages" artifact. | |||
| Unzip the packages.zip and then run: | |||
|
|
|||
| ```shell | |||
| PACKAGE=<package_name> anaconda upload **/$PACKAGE*.tar.bz2 --user memfault | |||
| PACKAGE=<package_name>; anaconda upload **/$PACKAGE*.tar.bz2 --user memfault | |||
martijnthe
reviewed
Dec 5, 2023
| @@ -313,7 +319,7 @@ dcap: | |||
| eclib: | |||
| - '20230424' | |||
| elfutils: | |||
| - 0.189.memfault1 | |||
There was a problem hiding this comment.
Revert? Want to keep the non-stub libdebuginfo.
martijnthe
reviewed
Dec 5, 2023
| "gdb-add-index" | ||
| "objcopy" | ||
| "objdump" | ||
| "readelf" |
There was a problem hiding this comment.
oh, thanks for keeping readelf. I need this :)
martijnthe
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Only issue I found is that the elfutils version should be using the ...memfault1 version. See comment
Since it's now released! Can also drop our old patch for the segfault issue on certain ARM backtraces 🙌 I took the opportunity to rename the output binaries to have the `multi-arch-` prefix, because it's really confusing to me to have `gdb` not be native `gdb` when in a conda environment with this package installed. Refreshed the `conda_build_config.yaml` to use the latest conda-build feedstock version at time of writing: ```bash ❯ curl -sSL https://github.com/conda-forge/conda-forge-pinning-feedstock/raw/main/recipe/conda_build_config.yaml > gdb-multi-arch/conda_build_config.yaml ``` Which is https://github.com/conda-forge/conda-forge-pinning-feedstock/blob/41ef3139dd637914a18f9609bf3d33a2f4780376/recipe/conda_build_config.yaml . This changes the supported + built python targets to: - 3.8 - 3.9 - 3.10 - 3.11 And include `readelf` in the package (`multi-arch-readelf`), since it can be pretty handy. Finally, `shfmt` the build script too since I'm in here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it's now released! Can also drop our old patch for the segfault
issue on certain ARM backtraces 🙌
I took the opportunity to rename the output binaries to have the
multi-arch-prefix, because it's really confusing to me to havegdbnot be native
gdbwhen in a conda environment with this packageinstalled.
Refreshed the
conda_build_config.yamlto use the latest conda-buildfeedstock version at time of writing:
❯ curl -sSL https://github.com/conda-forge/conda-forge-pinning-feedstock/raw/main/recipe/conda_build_config.yaml > gdb-multi-arch/conda_build_config.yamlWhich is
https://github.com/conda-forge/conda-forge-pinning-feedstock/blob/41ef3139dd637914a18f9609bf3d33a2f4780376/recipe/conda_build_config.yaml
.
This changes the supported + built python targets to:
And include
readelfin the package (multi-arch-readelf), since itcan be pretty handy.
Finally,
shfmtthe build script too since I'm in here.