Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: add lefthook, prettier, typos #481

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

lint: add lefthook, prettier, typos #481

wants to merge 1 commit into from

Conversation

noahp
Copy link
Contributor

@noahp noahp commented Jun 13, 2024

Install from npm, because it's simpler, so use lefthook as the
pre-commit runner (yarn install automatically installs the hooks,
which is somewhat nice too).

I removed the reference to the grammarly vscode extension, since it's
no longer available in the marketplace and the github repo is archived.

@noahp noahp requested review from gminn, tyhoff and sarfata and removed request for tyhoff June 13, 2024 13:43
Copy link

cloudflare-workers-and-pages bot commented Jun 13, 2024

Deploying interrupt with  Cloudflare Pages  Cloudflare Pages

Latest commit: 254461a
Status:🚫  Build failed.

View logs

Copy link
Member

@gminn gminn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for adding this! been wanting it for a while ❤️ Can't wait to open the massive formatting and typos fixing PR 💥

package.json Show resolved Hide resolved
readme.md Show resolved Hide resolved
Install from npm, because it's simpler, so use lefthook as the
pre-commit runner (`yarn install` automatically installs the hooks,
which is somewhat nice too).

I removed the reference to the `grammarly` vscode extension, since it's
no longer available in the marketplace and the github repo is archived.
@noahp noahp marked this pull request as ready for review July 17, 2024 12:40
@noahp noahp requested a review from gminn July 17, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants