Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ruby to 3.2.2, replace lunr.js with algolia search #493

Closed
wants to merge 5 commits into from

Conversation

noahp
Copy link
Contributor

@noahp noahp commented Jul 17, 2024

@noahp noahp requested a review from gminn July 17, 2024 12:33
@noahp noahp changed the title noahp/upgrade ruby take two Upgrade ruby to 3.2.2, replace lunr.js with algolia search Jul 17, 2024
Copy link

cloudflare-workers-and-pages bot commented Jul 17, 2024

Deploying interrupt with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0f666aa
Status: ✅  Deploy successful!
Preview URL: https://878875c5.interrupt.pages.dev
Branch Preview URL: https://noahp-upgrade-ruby-take-two-aug4.interrupt.pages.dev

View logs

Copy link
Member

@gminn gminn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple questions! The preview looks great 🤩 🔍

Gemfile.lock Outdated Show resolved Hide resolved
_includes/script.html Outdated Show resolved Hide resolved
Annoying that this is needed in new bundler version :/

`❯ bundle lock --add-platform universal-linux --add-platform universal-darwin`
Copy link
Member

@gminn gminn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! All good to go once we get the interrupt index

@noahp
Copy link
Contributor Author

noahp commented Oct 25, 2024

#528 replaces this, closing

@noahp noahp closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants