MFLT-12997 better sync_memfault_successful metric #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to how memfault data is typically sent over MQTT, the `sync_memfault_successful` built-in (zephyr port) metric doesn't fire, since that is set in the http uploader. Add the metric to the MQTT Memfault data uploader. Drive-by changes included: - update to Memfault SDK v1.5.2 - set a default static `software_version` of `0.0.99-dev`, which should be overridden at OTA image build time on the command line. this helps distinguish dev builds from OTA builds.
|
Some checks failed. Please fix and resubmit. checkpatch (informational only, not a failure)Identity/Emails issuesdc5f83c: author email (Noah Pendleton [email protected]) must be a real email and cannot end in @users.noreply.github.com Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages. |
gminn
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to how memfault data is typically sent over MQTT, the
sync_memfault_successfulbuilt-in (zephyr port) metric doesn't fire,since that is set in the http uploader.
Add the metric to the MQTT Memfault data uploader.
Drive-by changes included:
software_versionof0.0.99-dev, which shouldbe overridden at OTA image build time on the command line. this helps
distinguish dev builds from OTA builds.