Feature/project description #8
Conversation
.run/single-binary.run.xml
Outdated
| </component> No newline at end of file | ||
| </component> |
There was a problem hiding this comment.
Where does this change come from?
There was a problem hiding this comment.
Automatically changed from IntelliJ
cmd/single/start.go
Outdated
| projects := []config.Project{{Name: "flytesnacks", Description: "flytesnacks project"}} | ||
| if len(cfg.SeedProjects) > 0 { | ||
| for _, project := range cfg.SeedProjects { | ||
| projects = append(projects, config.Project{Name: project.Name, Description: project.Description}) | ||
| } |
There was a problem hiding this comment.
AFAIK it will keep "flytesnacks" even if someone defines his/her own projects, right? Previoulsy it wasn't the case
There was a problem hiding this comment.
You are right, I have fixed it
| @@ -73,7 +73,7 @@ func Test_tokenEndpoint(t *testing.T) { | |||
|
|
|||
| m := map[string]interface{}{} | |||
| assert.NoError(t, json.Unmarshal(rw.Body.Bytes(), &m)) | |||
| assert.Equal(t, 0.5*time.Hour.Seconds()-1, m["expires_in"]) | |||
| assert.GreaterOrEqual(t, m["expires_in"], 0.5*time.Hour.Seconds()-5) | |||
There was a problem hiding this comment.
Personally I would separate this using a dedicated fix but not sure if flyte guys care about
|
@robert-ulbrich-mercedes-benz please could you get rid of merge commits and squash changes into a single commit |
Signed-off-by: Rob Ulbrich <[email protected]>
robert-ulbrich-mercedes-benz
force-pushed
the
feature/project-description
branch
from
be13e66
to
4088241
Compare
I rebased the commits |
# Conflicts: # docker/sandbox-bundled/manifests/complete-agent.yaml # docker/sandbox-bundled/manifests/complete.yaml # docker/sandbox-bundled/manifests/dev.yaml # flyteadmin/pkg/manager/impl/testutils/mock_requests.go # flyteadmin/pkg/manager/impl/validation/execution_validator_test.go # flytepropeller/pkg/compiler/validators/bindings_test.go
|
Please add required footer sections to PR description as outlined here |
What exactly do you mean? I will close this pull request. I will not further follow it, but open a pull request against flyte. |
|
Completely aware of it. Nevertheless I'd prefer to have as much as possible being reviewed upfront. At least for me, legal notices are worth to be reviewed as well. |
I added the the legal notices. |
I think in PR desc follwing phrase is misssing: |
I adde the phrase. |
Why are the changes needed?
This change allows to set the description of a Flyte project. It could hold the responsible team for a Flyte project including the contact data or some other information.
What changes were proposed in this pull request?
flyte-coreHelm chart so they can hold a name and a description for the projectflyte-binaryand the single binary approach the structure of the Helm chart was changedHow was this patch tested?
flyteadmin migrate seed-projectswas tested with the adaptedflyte-single-binary-local.yamlconfig fileSetup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
The program was tested solely for our own use cases, which might differ from yours
Robert Ulbrich [email protected], Mercedes-Benz Tech Innovation GmbH, legal info/Impressum