Move all Llama Stack types to llama-stack #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwinb
requested review from
yanxi0830,
hardikjshah,
dltn,
raghotham and
ehhuang
as code owners
facebook-github-bot
added
the
CLA Signed
|
|
ashwinb
force-pushed
the
move_to_stack
branch
from
43afc48 to
1127165
Compare
ehhuang
approved these changes
Feb 14, 2025
ashwinb
added a commit
to meta-llama/llama-stack
that referenced
this pull request
Feb 14, 2025
…1098) llama-models should have extremely minimal cruft. Its sole purpose should be didactic -- show the simplest implementation of the llama models and document the prompt formats, etc. This PR is the complement to meta-llama/llama-models#279 ## Test Plan Ensure all `llama` CLI `model` sub-commands work: ```bash llama model list llama model download --model-id ... llama model prompt-format -m ... ``` Ran tests: ```bash cd tests/client-sdk LLAMA_STACK_CONFIG=fireworks pytest -s -v inference/ LLAMA_STACK_CONFIG=fireworks pytest -s -v vector_io/ LLAMA_STACK_CONFIG=fireworks pytest -s -v agents/ ``` Create a fresh venv `uv venv && source .venv/bin/activate` and run `llama stack build --template fireworks --image-type venv` followed by `llama stack run together --image-type venv` <-- the server runs Also checked that the OpenAPI generator can run and there is no change in the generated files as a result. ```bash cd docs/openapi_generator sh run_openapi_generator.sh ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llama-models should have extremely minimal cruft. Its sole purpose should be didactic -- show the simplest implementation of the llama models and document the prompt formats, etc.
As such:
datatypes.pyfile at the top-level containing a minimal list of datatypes. Nothing insidellama3/api/anymore.Similarly, all the registrations of various Llama SKUs, their parameters, etc. can arguably move to llama stack (although that is debatable) since only the Llama Stack CLI is concerned about those.
NOTE: *This PR cannot be landed until the corresponding llama-stack PR (which removes dependencies on llama-models) lands first. meta-llama/llama-stack#1098 *
Test Plan
(Partial, since most of the tests will be run on the Llama Stack side.)
Run chat completion: