New SLO shape improves compatibility + fix codecov uploads #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested with: - Azure AD - keycloak
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #83 +/- ##
==========================================
- Coverage 75.03% 75.00% -0.04%
==========================================
Files 10 10
Lines 693 692 -1
Branches 101 101
==========================================
- Hits 520 519 -1
Misses 72 72
Partials 101 101 ☔ View full report in Codecov by Sentry. |
noahmoss
previously approved these changes
Apr 29, 2024
escherize
changed the title
noahmoss
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keycloak is a little more lenient than Microsoft Azure Active Directory (aka Microsoft Entra ID). So I've updated the shape to match the Entra ID docs. This shape of a SLO logout request works on both.
Tested with: