LB-1585: Add Syndication Feeds to ListenBrainz #2962
Conversation
… text in the dropdown
|
@MonkeyDo : Can you please have a look at the UI bits of this PR? |
|
@ericd23 : For the URLs that are being used for the feeds, please use the API_URL from config -- on my dev box right now API_URL is set to a localhost address, but the URL goes to listenbrainz.org |
|
Where can I find the UI buttons for the other feeds (I know where the listens button is), but where are the others? |
|
Hi mayhem! For fresh releases and stats art, it's on the sidebar. For stats, it's on this page https://listenbrainz.org/user/ercd/stats/top-artists/?range=week. |
frontend/js/src/explore/fresh-releases/components/ReleaseFilters.tsx
Outdated
Show resolved
Hide resolved
frontend/js/tests/explore/fresh-releases/FreshReleases.test.tsx
Outdated
Show resolved
Hide resolved
frontend/js/src/explore/fresh-releases/components/ReleaseFilters.tsx
Outdated
Show resolved
Hide resolved
frontend/css/main.less
Outdated
| .feed-button { | ||
| cursor: pointer; | ||
| color: #353070; | ||
| } |
There was a problem hiding this comment.
This seems unused, and I think you overwrite the text color on the component using style, making it less useful.
I would suggest wrapping the SVG icon inside a parent div element with classes btn btn-icon feed-button.
The btn class handles curser pointer and all that, btn-icon makes a button with just the icon as content, and repurposing the feed-button class to adjust the padding and size:
| .feed-button { | |
| cursor: pointer; | |
| color: #353070; | |
| } | |
| .feed-button { | |
| padding: 0; | |
| height: auto; | |
| font-size: 1em; | |
| } |
|
I've got your code running on beta.listenbrainz.org right now and the Weekly Jams and Weekly Exploration Feeds have some issues:
|
|
The title of the "Feed: Site-wide Fresh Releases" feed says: "Fresh Releases - ListenBrainz" and the per user one says: "Fresh Releases for rob -- ListenBrainz". Looking at this, it isn't quite clear what the site-wide feed is for -- I think we should say "All Fresh Releases -- ListenBrainz". What do you think? |
|
The "Feed: Stats Art" also has a trailing ? in the URL. |
|
Also unclear is when an entry gets added to the stats art generator -- my feed is empty. (but then again, I have not generated feed art as of late -- should it be automatic?) |
|
Ahhh. I will have a look. |
|
For the art creator, I think it's because this beta API URL is not open for consumption. For art creator feed to work, I embed such API URL in the feed so that feed readers could display the SVG correctly. |
|
|
And yes, the trailing |
|
OK, the trailing ? has been fixed and the recommendations feed is fixed -- great. My stats are feed is still empty -- what actions cause new entries to appear in the feed there? |
|
Here: Simply put I embed an API call in the feed. And the base URL for this call is dependent on the env. Since the beta API cannot be used, the feed reader cannot retrieve the SVG. I guess we could temporarily patch the code to use api.listenbrainz.org in the feed content and see if it works ok. |
|
Ah, got it. That makes sense. OK, then I think we're pretty much ready to go merge this, save for one thing: Commenting out the Feed atom feed, since that isn't properly protected right now. Lets hide the feed button in the UI and comment out the API endpoint that corresponds to it. Also, please leave docs as to how to undo the comments once the OAuth stuff is done and rolled out. Thanks! |
|
Great! |
|
I think there's more to be done than just uncommenting the code once the oauth stuff is done. Once we are there, I will add necessary integration. Just let me know when it's time. I will keep an eye on the chat! |
|
Sounds good -- and we may be getting close to OAuth time -- may not be that long after all. I'm getting last bits of feedback from @Aerozol and @amCap1712, just to make sure we didn't miss anything. |
| @@ -171,12 +218,14 @@ def get_listens(user_name): | |||
|
|
|||
| content = render_template( | |||
| "atom/listens.html", | |||
| user_page_url=_external_url_for("user.index", path="", user_name=user_name), | |||
| user_page_url=_external_url_for( | |||
| "user.index", path="", user_name=user_name), | |||
| user_name=user_name, | |||
| recording_mb_page_base_url="https://musicbrainz.org/recording/", | |||
| track_name=track_name, | |||
| recording_mbid=recording_mbid, | |||
There was a problem hiding this comment.
Unable to comment a few lines above so doing it here, I think the listens should fallback to using mapped mbid data if the additional_info doesn't have the required fields? But not a blocker for merging, we can do this later as well.
|
Hi! Did you see this document from Aerozol? https://docs.google.com/document/d/10K6JK-9Ytc9lY3cyfjTRyJAmJggaBSNsli2_0-iZ0ks/edit Its has some UI cleanup that we should do before merging. Do you have time to work on this? |
|
Yes I can work on this next week and I will talk to aerozol. |
No description provided.