Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Packages/vue-component] fix: component registration with meteor 1.8.2 #380

Merged
merged 2 commits into from
Dec 27, 2019

Conversation

jbl2024
Copy link
Contributor

@jbl2024 jbl2024 commented Nov 29, 2019

See #364

require behavior has changed in meteor 1.8.2

require behavior has changed in meteor 1.8.2
@jaumeMR
Copy link

jaumeMR commented Dec 5, 2019

This change prevents it from working in legacy browsers. With this small addition I have it working on them:

js += `\nvar _Vue = require('vue').default;
      if (!_Vue) _Vue = require('vue');
      _Vue.component(__vue_options__.name, __vue_script__);\n`

@mullojo
Copy link

mullojo commented Dec 20, 2019

It would really help me a lot if this fix could be implemented! @Akryum , have you been able to take a look into this yet? Much thanks! I would be happy to contribute on Patreon for all the great work you have done on Meteor + Vue. I started a project a year ago and have heavily dependant on your packages and work. Thank you! Bob

@mullojo
Copy link

mullojo commented Dec 20, 2019

Hi @mitar, if @Akryum can't get to this, would you be able to make this change? I would really appreciate this fix!

@mitar
Copy link
Member

mitar commented Dec 20, 2019

This looks reasonable for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants