feat!: sanitize theme footer's templates #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfontanini
added a commit
that referenced
this pull request
Feb 28, 2025
After #442 you could no longer use braces unless it was to refer to a variable. This PR softens that restriction by letting you use double braces as an "escaped brace" to let you use them anywhere. e.g. this footer "{title} {{potato}}" will render as "<title> {{potato}}"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sanitizes the theme footer's template so that we have sure that it's not malformed and doesn't reference any variables that can't be used (e.g.
{bar}). This now also avoids allocation a bunch of strings when rendering the footer, since every variable was being replaced viastr::replace.This is a breaking change for anyone who already has a malformed string in their string templates. If someone does use a string like
{lord} Georgein their footer please bring it up and we can see what to do.