Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added docker compose file. #533

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

added docker compose file. #533

wants to merge 10 commits into from

Conversation

ArpitBlagan
Copy link

@ArpitBlagan ArpitBlagan commented Jul 23, 2024

Screenshot 2024-07-23 at 10 14 12 AM

@ArpitBlagan ArpitBlagan requested a review from mfts as a code owner July 23, 2024 04:03
Copy link

vercel bot commented Jul 23, 2024

Someone is attempting to deploy a commit to the mftsio Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Owner

@mfts mfts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good. There's another PR open for a pure dockerfile #532. But I definitely like the docker-compose approach with the database.

Would it be possible to specify the different env variables before running the docker compose? Like notification emails won't work without Resend currently. Planning to offer also smtp, for self-hosting. Currently we also rely on trigger, but might be able to escape that for self-hosting.

docker-compose.yml Outdated Show resolved Hide resolved
@ArpitBlagan ArpitBlagan reopened this Jul 23, 2024
@ArpitBlagan
Copy link
Author

Yes before running docker compose up just simple create .env file and change or add all the variables that are needed.

@ArpitBlagan ArpitBlagan requested a review from mfts July 23, 2024 11:52
@bndrgroup bndrgroup mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants