Fix PHPStan level-5 errors

mibk · Nov 18, 2020 · 816acd2 · 816acd2
1 parent c0d1403
commit 816acd2
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/LeanMapperQuery/Entity.php b/LeanMapperQuery/Entity.php
@@ -98,7 +98,9 @@ public static function queryEntityProperty(LeanMapper\Entity $entity, $field, IQ
 				if ($row !== null && $targetResultProxy === null) {
 					$targetResultProxy = $row->getResultProxy();
 				}
-				$row !== null && $resultRows[$row->{$targetPrimaryKey}] = $row;
+				if ($row !== null) {
+					$resultRows[$row->{$targetPrimaryKey}] = $row;
+				}
 			}
 
 			if ($targetResultProxy) {

diff --git a/LeanMapperQuery/Query.php b/LeanMapperQuery/Query.php
@@ -266,7 +266,7 @@ private function traverseToRelatedEntity(&$currentTable, &$currentTableAlias, Pr
 			$targetTableAlias = $this->joinRelatedTable($relationshipTableAlias, $targetReferencingColumn, $targetTable, $targetTablePrimaryKey, $implicitFilters, false);
 
 		} else {
-			throw new InvalidRelationshipException('Unknown relationship type. ' . get_class($relationship) . ' given.');
+			throw new InvalidRelationshipException('Unknown relationship type in property {$property->getName()}.');
 		}
 		$currentTable = $targetTable;
 		$currentTableAlias = $targetTableAlias;

diff --git a/phpstan.neon b/phpstan.neon
@@ -1,4 +1,4 @@
 parameters:
-	level: 3
+	level: 5
 	paths:
 		- LeanMapperQuery/