Don't test the installer, since it requires an internet connection (#20)

Internet connections can be flaky, so tests should not rely on them
michaelcontento · Apr 2, 2017 · c0917d0 · c0917d0
1 parent 11d8aa7
commit c0917d0
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 14 deletions.
diff --git a/tests/installer.bats b/tests/installer.bats
@@ -0,0 +1,21 @@
+#!/usr/bin/env bats
+
+setup() {
+    cd $BATS_TEST_DIRNAME
+    unset CIRCLE_NODE_TOTAL
+    unset CIRCLE_NODE_INDEX
+}
+
+@test "installer" {
+    rm -rf ~/.local/bin/circleci-matrix
+    # Only remove the whole folder if it's empty!
+    if [ $(ls -1 ~/.local/bin | wc -l) -eq 0 ]; then
+        rm -rf ~/.local/bin
+    fi
+
+    $BATS_TEST_DIRNAME/../src/install.sh
+
+    [ -f ~/.local/bin/circleci-matrix ]
+    [ -x ~/.local/bin/circleci-matrix ]
+    ~/.local/bin/circleci-matrix --version
+}
diff --git a/tests/run.bats b/tests/run.bats
@@ -10,20 +10,6 @@ circleci-matrix() {
     $BATS_TEST_DIRNAME/../src/circleci-matrix.sh $@
 }
 
-@test "installer" {
-    rm -rf ~/.local/bin/circleci-matrix
-    # Only remove the whole folder if it's empty!
-    if [ $(ls -1 ~/.local/bin | wc -l) -eq 0 ]; then
-        rm -rf ~/.local/bin
-    fi
-
-    $BATS_TEST_DIRNAME/../src/install.sh
-
-    [ -f ~/.local/bin/circleci-matrix ]
-    [ -x ~/.local/bin/circleci-matrix ]
-    ~/.local/bin/circleci-matrix --version
-}
-
 @test "print version" {
     circleci-matrix | grep "circleci-matrix version: 1.0.0"
 }