Merge pull request #745 from microlinkhq/next

fix(logo-favicon): ensure body is present

packages/metascraper-logo-favicon/src/index.js

@@ -148,7 +148,8 @@ const defaultResolveFaviconUrl = async (faviconUrl, contentTypes, gotOpts) => {
     return undefined
   }
 
-  if (contentTypes && response.body.toString()[0] === '<') {
+  // 60 is the ASCII code for '<'
+  if (contentTypes && (!response.body || response.body[0] === 60)) {
     return undefined
   }
 

packages/metascraper-logo-favicon/test/resolve-favicon-url.js

@@ -1,6 +1,7 @@
 'use strict'
 
 const test = require('ava')
+const got = require('got')
 
 const { resolveFaviconUrl } = require('..')
 const { runServer } = require('./helpers')
@@ -24,6 +25,21 @@ test('undefined if content type is not expected', async t => {
   t.is(await resolveFaviconUrl(toUrl(url, 'favicon.ico'), []), undefined)
 })
 
+test('undefined if body is not present', async t => {
+  const url = await runServer(t, async ({ res }) => {
+    const stream = got.stream(
+      'https://cdn.microlink.io/file-examples/sample-big.jpg'
+    )
+    stream.pipe(res)
+    setTimeout(() => res.destroy(), 100)
+  })
+
+  t.is(
+    await resolveFaviconUrl(url, ['jpg', ['image/jpeg']], { retry: 0 }),
+    undefined
+  )
+})
+
 test('undefined if body is not the expected according to content type', async t => {
   const url = await runServer(t, async ({ res }) => {
     res.setHeader('content-type', 'image/x-icon')