Skip to content

Commit

Permalink
Merge pull request #705 from microlinkhq/next
Browse files Browse the repository at this point in the history
test: update snapshots
  • Loading branch information
Kikobeats authored May 20, 2024
2 parents 86ed64c + d5c680e commit 8acbccf
Show file tree
Hide file tree
Showing 12 changed files with 70 additions and 75 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ const metascraper = require('metascraper')([
- [metascraper-telegram](https://github.com/microlinkhq/metascraper/tree/master/packages/metascraper-telegram) – Metascraper integration with Telegram.
- [metascraper-uol](https://github.com/microlinkhq/metascraper/tree/master/packages/metascraper-uol) – Metascraper integration for uol.com URLs.
- [metascraper-spotify](https://github.com/microlinkhq/metascraper/tree/master/packages/metascraper-spotify) – Metascraper integration with Spotify.
- [metascraper-twitter](https://github.com/microlinkhq/metascraper/tree/master/packages/metascraper-twitter) – Metascraper integration with Twitter.
- [metascraper-x](https://github.com/microlinkhq/metascraper/tree/master/packages/metascraper-x) – Metascraper integration with x.com.
- [metascraper-youtube](https://github.com/microlinkhq/metascraper/tree/master/packages/metascraper-youtube) – Metascraper integration with YouTube.

### Community
Expand Down
2 changes: 1 addition & 1 deletion packages/metascraper-x/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<img style="width: 500px; margin:3rem 0 1.5rem;" src="https://metascraper.js.org/static/logo-banner.png" alt="metascraper">
<br>
<br>
<p align="center"><strong>metascraper-x</strong>: Metascraper integration for x.com.</p>
<p align="center"><strong>metascraper-x</strong>: Metascraper integration with x.com.</p>
<p align="center">See our <a href="https://metascraper.js.org" target='_blank' rel='noopener noreferrer'>website</a> for more information.</p>
<br>
</div>
Expand Down
2 changes: 1 addition & 1 deletion packages/metascraper-x/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "metascraper-x",
"description": "Metascraper integration for x.com",
"description": "Metascraper integration with x.com",
"homepage": "https://github.com/microlinkhq/metascraper/packages/metascraper-x",
"version": "5.45.7",
"types": "src/index.d.ts",
Expand Down
2 changes: 1 addition & 1 deletion packages/metascraper-x/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ module.exports = ({
title: [toTitle(($, url) => `@${url.split('/')[3]} on X`)],
url: [
toUrl($ =>
$('link[rel="canonical"]').attr('href').replace('twitter.com', 'x.com')
$('link[rel="canonical"]').attr('href')?.replace('twitter.com', 'x.com')
)
],
description: [
Expand Down
6 changes: 3 additions & 3 deletions packages/metascraper/test/integration/twitter-gif/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const { resolve } = require('path')
const test = require('ava')

const metascraper = require('../../..')([
require('metascraper-twitter')(),
require('metascraper-x')(),
require('metascraper-author')(),
require('metascraper-date')(),
require('metascraper-description')(),
Expand All @@ -22,9 +22,9 @@ const metascraper = require('../../..')([
require('metascraper-readability')()
])

const url = 'https://twitter.com/Kikobeats/status/880139124791029763'
const url = 'https://x.com/Kikobeats/status/880139124791029763'

test('twitter (tweet with gif)', async t => {
test('x.com (tweet with gif)', async t => {
const html = await readFile(resolve(__dirname, 'input.html'))
const metadata = await metascraper({ html, url })
t.snapshot(metadata)
Expand Down
75 changes: 25 additions & 50 deletions packages/metascraper/test/integration/twitter-gif/input.html

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -4,20 +4,20 @@ The actual snapshot is saved in `index.js.snap`.

Generated by [AVA](https://avajs.dev).

## twitter (tweet with gif)
## x.com (tweet with gif)

> Snapshot 1
{
audio: null,
author: '#!/kiko/beats (Kikobeats)',
date: null,
date: '2024-05-20T12:49:13.000Z',
description: 'Experimenting with Clearbit API + Apple TV 3D Parallax https://t.co/Qsm163k4mJ',
image: 'https://pbs.twimg.com/tweet_video_thumb/DDbh3WCXYAAZfz9.jpg:large',
lang: 'en',
logo: 'https://abs.twimg.com/favicons/twitter.3.ico',
publisher: 'X',
title: '@Kikobeats on X',
url: 'https://twitter.com/Kikobeats/status/880139124791029763',
url: 'https://x.com/Kikobeats/status/880139124791029763',
video: null,
}
Binary file not shown.
6 changes: 3 additions & 3 deletions packages/metascraper/test/integration/twitter-image/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const { resolve } = require('path')
const test = require('ava')

const metascraper = require('../../..')([
require('metascraper-twitter')(),
require('metascraper-x')(),
require('metascraper-author')(),
require('metascraper-date')(),
require('metascraper-description')(),
Expand All @@ -22,9 +22,9 @@ const metascraper = require('../../..')([
require('metascraper-readability')()
])

const url = 'https://twitter.com/k4rliky/status/934482867480121345'
const url = 'https://x.com/UaSmart/status/934106870834454529'

test('twitter (tweet with image)', async t => {
test('x.com (tweet with image)', async t => {
const html = await readFile(resolve(__dirname, 'input.html'))
const metadata = await metascraper({ html, url })
t.snapshot(metadata)
Expand Down
30 changes: 25 additions & 5 deletions packages/metascraper/test/integration/twitter-image/input.html

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -4,20 +4,20 @@ The actual snapshot is saved in `index.js.snap`.

Generated by [AVA](https://avajs.dev).

## twitter (tweet with image)
## x.com (tweet with image)

> Snapshot 1
{
audio: null,
author: 'I don’t know, but I’ll find out. - Marty Sklar (k4rliky)',
date: null,
description: 'Lo mejor de @codemotion_es #codemotionMadrid es estar con la gente que quieres 😍@ladyCircus',
image: 'https://pbs.twimg.com/media/DPfzNMGXUAESoL3.jpg:large',
author: 'SmartUA (UaSmart)',
date: '2024-05-20T12:50:36.000Z',
description: 'Y terminamos el dia con Cultura de empresa con @patoroco, @flopezluis, Katia, Angélica en @codemotion_es #codemotion2017',
image: 'https://pbs.twimg.com/media/DPadOKpXcAIL-NW.jpg:large',
lang: 'en',
logo: 'https://abs.twimg.com/favicons/twitter.3.ico',
publisher: 'X',
title: '@k4rliky on X',
url: 'https://twitter.com/k4rliky/status/934482867480121345',
title: '@UaSmart on X',
url: 'https://x.com/UaSmart/status/934106870834454529',
video: null,
}
Binary file not shown.

0 comments on commit 8acbccf

Please sign in to comment.