feat!: remove process global to work outside of node #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I realize now that My use case is actually babel attempting to read I think this PR is still useful though since the default value assumed |
|
@styfle thanks for the PR. I agree with all of your points. I'll get this merged in an probably publish a major asap. Thanks! |
|
@jonschlinkert Thanks for the quick response! 🎉 |
|
Done, I just published v4.0. If anyone wants to do a PR in micromatch to upgrade picomatch to latest, I'd be happy to accept. |
|
Great! I created a micromatch PR here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support more JS runtimes besides Node.js, this PR drops the check for
processglobal.The
processglobal was only used to improve the error message for Node.js less than 10 (released April 2018).This could be considered a breaking change since the error message will change, however this package already specifies package.json
engines.nodewith>=10, so perhaps no one can even run it on older versions of Node.js without an install error.picomatch/package.json
Line 20 in 5214db4