Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable scheduled shutdown of Guacamole Windows VMs #4211

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

marrobi
Copy link
Member

@marrobi marrobi commented Dec 18, 2024

Fixes #4205

Add support for scheduled shutdown of Guacamole Windows VMs.

  • Add enable_shutdown_schedule, shutdown_time, and shutdown_timezone properties to template_schema.json.
  • Add enable_shutdown_schedule, shutdown_time, and shutdown_timezone parameters to porter.yaml.
  • Add azurerm_dev_test_global_vm_shutdown_schedule resource to windowsvm.tf.
  • Add enable_shutdown_schedule, shutdown_time, and shutdown_timezone variables to variables.tf.
  • Update bundle version in porter.yaml.

For more details, open the Copilot Workspace session.

Fixes #4205

Add support for scheduled shutdown of Guacamole Windows VMs.

* Add `enable_shutdown_schedule`, `shutdown_time`, and `shutdown_timezone` properties to `template_schema.json`.
* Add `enable_shutdown_schedule`, `shutdown_time`, and `shutdown_timezone` parameters to `porter.yaml`.
* Add `azurerm_dev_test_global_vm_shutdown_schedule` resource to `windowsvm.tf`.
* Add `enable_shutdown_schedule`, `shutdown_time`, and `shutdown_timezone` variables to `variables.tf`.
* Update bundle version in `porter.yaml`.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/AzureTRE/issues/4205?shareId=XXXX-XXXX-XXXX-XXXX).
@marrobi marrobi marked this pull request as draft December 18, 2024 16:43
Copy link

github-actions bot commented Dec 18, 2024

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit f775a5c.

♻️ This comment has been updated with latest results.

@marrobi marrobi marked this pull request as ready for review February 17, 2025 13:47
@marrobi marrobi requested a review from yuvalyaron February 19, 2025 20:16
Copy link
Collaborator

@yuvalyaron yuvalyaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Scheduled Shutdown of Guacamole Windows VMs
2 participants