Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish RPM packages for Azure Linux in the release job #6774

Merged
merged 8 commits into from
Jan 30, 2025

Conversation

maxtropets
Copy link
Collaborator

@maxtropets maxtropets commented Jan 24, 2025

Resolves #6760

Ignore release-test.yml, will be deleted before merging

@maxtropets maxtropets self-assigned this Jan 24, 2025
@maxtropets maxtropets added 1.x-backport Highlights PRs targeting the 1.x branch release-test and removed 1.x-backport Highlights PRs targeting the 1.x branch release-test labels Jan 24, 2025
@maxtropets maxtropets force-pushed the f/rpm-packages-azure-linux branch 9 times, most recently from 798060b to 647eaf0 Compare January 28, 2025 17:49
@maxtropets maxtropets changed the title [WIP] [DRAFT] Initial split to rpm/deb Publish RPM packages in release job Jan 29, 2025
@maxtropets maxtropets changed the title Publish RPM packages in release job Publish RPM packages in the release job Jan 29, 2025
@maxtropets maxtropets force-pushed the f/rpm-packages-azure-linux branch from 41a4c88 to 763d62c Compare January 29, 2025 11:04
@maxtropets maxtropets changed the title Publish RPM packages in the release job Publish RPM packages for Azure Linux in the release job Jan 29, 2025
@maxtropets maxtropets marked this pull request as ready for review January 29, 2025 11:22
@maxtropets maxtropets requested a review from a team as a code owner January 29, 2025 11:22
@@ -0,0 +1,366 @@
name: Release (test)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file before merging

scripts/ci-checks.sh Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
@maxtropets maxtropets force-pushed the f/rpm-packages-azure-linux branch 3 times, most recently from 58da68f to a3211c3 Compare January 30, 2025 13:02
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@maxtropets maxtropets force-pushed the f/rpm-packages-azure-linux branch 2 times, most recently from f98fb8d to 19a7f48 Compare January 30, 2025 13:31
@achamayou
Copy link
Member

achamayou commented Jan 30, 2025

Deleting the contents of '/__w/CCF/CCF'
The repository will be downloaded using the GitHub REST API
To create a local Git repository instead, add Git 2.18 or higher to the PATH

Looks like git isn't installed, so GH is helpful and grabs a tarball, but then that fails in the version calculation later that needs to be able to look at tags.

I think it may be necessary to have a hardcoded step that sets up the gpg key, updates tdnf, and installs git first (is this a legit use of a composite action to avoid copy pasting? @eddyashton?), after which the checkout can take place, and then the deps install from the script.

@maxtropets maxtropets force-pushed the f/rpm-packages-azure-linux branch from 19a7f48 to 9cbe26f Compare January 30, 2025 14:51
@maxtropets maxtropets force-pushed the f/rpm-packages-azure-linux branch from c1a758e to 0ef1933 Compare January 30, 2025 15:32
@maxtropets maxtropets added the run-long-test Run Long Test job label Jan 30, 2025
@maxtropets maxtropets merged commit 118bcd1 into microsoft:main Jan 30, 2025
6 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release CCF packages for Azure Linux
3 participants