Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-package] add conda dir for LIBR_CORE_LIBRARY (fixes #3045) #3046

Merged
merged 2 commits into from
May 4, 2020

Conversation

jameslamb
Copy link
Collaborator

I think that conda installations of R put the core library at ${R_HOME}/lib. See #3045 (comment) and the rest of #3045 for details.

@StrikerRUS I created this as a LightGBM branch so it can be tested on readthedocs. Could you enable this branch there?

@jameslamb jameslamb requested a review from StrikerRUS May 4, 2020 00:22
@jameslamb jameslamb requested a review from Laurae2 as a code owner May 4, 2020 00:22
@jameslamb jameslamb added the fix label May 4, 2020
@StrikerRUS
Copy link
Collaborator

Just enabled builds for this branch.

@jameslamb
Copy link
Collaborator Author

Just enabled builds for this branch.

Thanks! The AppVeyor looks like #1818. Will push an empty commit to re-trigger it.

Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Many thanks!

image

@jameslamb
Copy link
Collaborator Author

Perfect! Many thanks!

image

woo! I'll merge as soon as CI passes. Glad we could resolve it quickly!

@jameslamb
Copy link
Collaborator Author

ugh more TeX problems

image

This is not broken on AppVeyor.

It can't possibly be related to the change in this PR :/

@StrikerRUS
Copy link
Collaborator

ugh more TeX problems

Rerunning...

@StrikerRUS StrikerRUS merged commit 5e0958f into master May 4, 2020
@StrikerRUS StrikerRUS deleted the jameslamb/fix/find-lib-r branch May 4, 2020 02:46
@StrikerRUS
Copy link
Collaborator

Failing in master at Azure with weird error:

R CMD check build logs:
* installing *source* package 'lightgbm' ...
** using staged installation
** libs
      0 [main] make 5052 child_info_fork::abort: D:\a\1\s\RLibrary\Rtools\bin\msys-gcc_s-1.dll: Loaded to different address: parent(0x6A0000) != child(0x170000)
make: fork: Resource temporarily unavailable
ERROR: compilation failed for package 'lightgbm'

Rerunning...

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants