Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests][dask] Increase number of partitions in data #4149

Closed
wants to merge 7 commits into from
Closed

[tests][dask] Increase number of partitions in data #4149

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f484d0b
increase partitions to 20 in _create_data to avoid having workers wit…
jmoralez Apr 1, 2021
cde4fc0
merge master
jmoralez Apr 3, 2021
981084f
increase top_rate for goss in test_classifier
jmoralez Apr 3, 2021
c6f1115
merge master
jmoralez Apr 6, 2021
0a6cc22
merge master
jmoralez Apr 23, 2021
d85c54a
merge master
jmoralez Jul 13, 2021
4df2898
Merge branch 'master' into tests/more-partitions
jmoralez Jul 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/python_package_test/test_dask.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ def _create_ranking_data(n_samples=100, output='array', chunk_size=50, **kwargs)
return X, y, w, g_rle, dX, dy, dw, dg


def _create_data(objective, n_samples=1_000, output='array', chunk_size=500, **kwargs):
def _create_data(objective, n_samples=1_000, output='array', chunk_size=50, **kwargs):
if objective.endswith('classification'):
if objective == 'binary-classification':
centers = [[-4, -4], [4, 4]]
Expand Down Expand Up @@ -198,7 +198,7 @@ def _create_data(objective, n_samples=1_000, output='array', chunk_size=500, **k

def _r2_score(dy_true, dy_pred):
numerator = ((dy_true - dy_pred) ** 2).sum(axis=0, dtype=np.float64)
denominator = ((dy_true - dy_pred.mean(axis=0)) ** 2).sum(axis=0, dtype=np.float64)
denominator = ((dy_true - dy_true.mean(axis=0)) ** 2).sum(axis=0, dtype=np.float64)
jameslamb marked this conversation as resolved.
Show resolved Hide resolved
return (1 - numerator / denominator).compute()


Expand Down Expand Up @@ -273,7 +273,7 @@ def test_classifier(output, task, boosting_type, client):
p2_proba = local_classifier.predict_proba(X)
s2 = local_classifier.score(X, y)

if boosting_type == 'rf' and output == 'dataframe-with-categorical':
jmoralez marked this conversation as resolved.
Show resolved Hide resolved
if boosting_type == 'rf':
# https://github.com/microsoft/LightGBM/issues/4118
assert_eq(s1, s2, atol=0.01)
assert_eq(p1_proba, p2_proba, atol=0.8)
Expand Down