-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Add debian-clang-devel CI job for the R package #4164
Conversation
Seems like this check is working! CUDA jobs are failing for probably-unrelated reasons (#4158 (comment)), but I can see that that new debian-clang-devel job failed with exactly the same error as seen on CRAN. https://github.com/microsoft/LightGBM/pull/4164/checks?check_run_id=2275252015 |
@StrikerRUS I received an email from Guolin yesterday. CRAN is asking us fix this problem and re-submit.
I think it's very important that I'll update this PR to make sure the package passes tests on @StrikerRUS which of these options would you prefer? I'm ok with whichever one you want, so we can come to a quick resolution well before April 21.
|
@jameslamb I'd prefer variant 2. Luckly, we haven't merged any breaking changes that doesn't fit for minor release into |
ok sounds good! I'll get this PR working today, and I'll open a separate PR for the release with the usual release checklist. |
/gha run r-solaris Workflow Solaris CRAN check has been triggered! 🚀 solaris-x86-patched: https://builder.r-hub.io/status/lightgbm_3.2.0.99.tar.gz-c7db3e53db4e4344bf08bf7f18b4af43 |
Ok I think the debian check will pass now! |
I've pushed empty commit with the aim to re-run CI and not overwrite important logs for Dask ranker error at the same time. |
@@ -1229,7 +1234,7 @@ test_that("lgb.train() supports non-ASCII feature names", { | |||
# UTF-8 strings are not well-supported on Windows | |||
# * https://developer.r-project.org/Blog/public/2020/05/02/utf-8-support-on-windows/ | |||
# * https://developer.r-project.org/Blog/public/2020/07/30/windows/utf-8-build-of-r-and-cran-packages/index.html | |||
if (!ON_WINDOWS) { | |||
if (UTF8_LOCALE && !ON_WINDOWS) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for improving testing CRAN environment coverage!
Co-authored-by: Nikita Titov <[email protected]>
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
The R package failed on CRAN check on its most recent submission (documented in #4105).
This PR proposes a CI job that attempts to replicate that environment, so that similar problems can be caught before submitting to CRAN in the future.
Following the suggestion in #4105 (comment), this tries to replicate CRAN's
r-devel-linux-x86_64-debian-clang
test, using the same container image that R Hub uses for that purpose.