-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update versions of LightGBM dependencies #4935
Conversation
All failing CI jobs are R-package jobs and the error is about hidden files:
|
Adding additional rules in https://github.com/microsoft/LightGBM/blob/master/R-package/.Rbuildignore should fix that. |
Here is a description for them in the original PR where they were introduced:
According to this, I agree that we can safely ignore/remove them. |
https://dev.azure.com/lightgbm-ci/lightgbm-ci/_build/results?buildId=11943&view=logs&j=275189f9-c769-596a-7ef9-49fb48a9ab70&t=3a9e7a4a-04e6-52a0-67ea-6e8f6cfda74f |
The latest commit passes all CI checks. I'd like to run CI multiple times to identify flaky test and affected environments.
|
Seems that failing test is LightGBM/tests/python_package_test/test_engine.py Line 2285 in ce486e5
and I guess that segfault happens here LightGBM/tests/python_package_test/test_engine.py Line 2304 in ce486e5
LightGBM/include/LightGBM/utils/common.h Lines 359 to 360 in b0137de
|
Reverting
Swapped compilers
|
I think this PR is ready for review. Based on 15 successful CI runs we can hope that this dependencies version upgrade is quite stable. I triggered all 15 runs via with empty commits because I noticed that sometimes if you re-run CI via closing-reopening a PR or by manually clicking rerun UI button (for those CIs where it's possible) new re-triggered CI job may reuse a previous runner, which breaks independency of tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for the thorough testing and explanation about fast_double_parser
.
Just marked this PR as |
Well, I think this PR is ready for review. |
Thanks for the very thorough testing! I support merging this. Pretty exciting, looks like there have been a lot of improvements in Eigen from the version currently shipped with LightGBM to now. For example, https://eigen.tuxfamily.org/index.php?title=3.4. |
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Refer to #3763.
All dependencies were updated to the latest available stable version.
https://github.com/boostorg/compute/releases/tag/boost-1.78.0
https://gitlab.com/libeigen/eigen/-/releases/3.4.0
https://github.com/lemire/fast_double_parser/releases/tag/v0.5.0see #4935 (comment)https://github.com/fmtlib/fmt/releases/tag/8.1.1