[ci] update some linting versions #6598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
commented
Aug 9, 2024
| @@ -53,7 +53,7 @@ def _create_data(task, n_samples=100, n_features=4): | |||
| elif task == "multiclass-classification": | |||
| centers = 3 | |||
| else: | |||
| ValueError(f"Unknown classification task '{task}'") | |||
| raise ValueError(f"Unknown classification task '{task}'") | |||
There was a problem hiding this comment.
From ruff:
tests/python_package_test/test_sklearn.py:56:13: PLW0133 Missing `raise` statement on exception
|
54 | centers = 3
55 | else:
56 | ValueError(f"Unknown classification task '{task}'")
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ PLW0133
57 | X, y = make_blobs(n_samples=n_samples, n_features=n_features, centers=centers, random_state=42)
58 | g = None
|
= help: Add `raise` keyword
Found 1 error.
jameslamb
commented
Aug 9, 2024
| OS_NAME: 'linux' | ||
| PYTHON_VERSION: '3.12' | ||
|
|
||
| jobs: | ||
| test: | ||
| name: ${{ matrix.task }} | ||
| runs-on: ubuntu-22.04 | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
This will prevent needing to update this OS version in the future. I don't think there's any reason this job needs to be on 22.04 specifically.
jameslamb
commented
Aug 9, 2024
| @@ -17,13 +17,14 @@ concurrency: | |||
|
|
|||
| env: | |||
| COMPILER: 'gcc' | |||
| MAKEFLAGS: '-j4' | |||
There was a problem hiding this comment.
While looking at this configuration, I realized that the check-r-docs job is installing a bunch of R packages on Linux. CRAN doesn't provide Linux binaries, so that means they're all being compiled from source.
Parallelizing compilation should speed that job up, as we do with the other R jobs:
LightGBM/.github/workflows/r_package.yml
Line 26 in e7edb6c
jameslamb
commented
Aug 9, 2024
jameslamb
changed the title
jameslamb
requested review from
guolinke,
shiyu1994,
jmoralez,
borchero and
StrikerRUS
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #3763.
Updates some linting versions.
conda install'd stuff for thelintandcheck-docstestspre-commithook versions frompre-commit autoupdateHappy to say the newest version of
ruffcaught a bug... a Python test that could accidentally not raise an exception because of a missingraisestatement! This fixes that as well.